Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD #286]Bump the onxy version #23695

Closed
wants to merge 1 commit into from
Closed

[HOLD #286]Bump the onxy version #23695

wants to merge 1 commit into from

Conversation

hayata-suenaga
Copy link
Contributor

@hayata-suenaga hayata-suenaga commented Jul 26, 2023 •
edited
Loading

This is still draft. The Onyx PR needs a link to a PR that updates Onyx version so I created this early.

Need to run npm i to update package-lock.json

Details

Onyx will be updated. Bump the Onyx version after this PR is merged.

Fixed Issues

$ Expensify/react-native-onyx#285
PROPOSAL: N/A

Tests

@hayata-suenaga hayata-suenaga requested a review from a team as a code owner July 26, 2023 20:57
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@hayata-suenaga hayata-suenaga self-assigned this Jul 26, 2023
@melvin-bot melvin-bot bot removed the request for review from a team July 26, 2023 20:58
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

@bondydaa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from bondydaa July 26, 2023 20:58
@hayata-suenaga hayata-suenaga changed the title Bump the onxy version [HOLD #286]Bump the onxy version Jul 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@hayata-suenaga
Copy link
Contributor Author

This is still draft. The Onyx PR needs a link to a PR that updates Onyx version so I created this early.

Need to run npm i to update package-lock.json

@hayata-suenaga hayata-suenaga marked this pull request as draft July 26, 2023 21:10
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

This was referenced Jul 26, 2023
Closed
Merged
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Jul 26, 2023

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@hayata-suenaga
Copy link
Contributor Author

This PR will bump the version so closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bondydaa bondydaa Awaiting requested review from bondydaa

Assignees

@hayata-suenaga hayata-suenaga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hayata-suenaga